Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for parsing iCCP chunk. #285

Merged
merged 1 commit into from
Feb 19, 2021
Merged

Add support for parsing iCCP chunk. #285

merged 1 commit into from
Feb 19, 2021

Conversation

jrmuizel
Copy link
Contributor

No description provided.

fintelia
fintelia reviewed Feb 18, 2021
View reviewed changes
src/decoder/stream.rs Outdated Show resolved Hide resolved
HeroicKatora
HeroicKatora approved these changes Feb 19, 2021
View reviewed changes
Copy link
Member

@HeroicKatora HeroicKatora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough for me, I'll make a note that the finish-phase of ZlibDecoder needs some way to check for bounds on the output vector size. We can merge with the one formatting nit fixed.

@HeroicKatora HeroicKatora mentioned this pull request Feb 19, 2021
Open
@jrmuizel
Copy link
Contributor Author

Done.

@HeroicKatora HeroicKatora merged commit bbd3f6f into image-rs:master Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fintelia fintelia fintelia left review comments

@HeroicKatora HeroicKatora HeroicKatora approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jrmuizel @fintelia @HeroicKatora