Make gAMA and cHRM fallback optional for sRGB #547
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
sRGB
chunk is sufficient on its own, so it'd be nice to be able to skip writinggAMA
/cHRM
fallback. I don't think there's value in adding the fallback by default. I assume that decoders too old to understandsRGB
chunk are also too old to have good color profile support, so passing through unlabelled sRGB pixels may be safer for them.The fallback is still possible if someone sets the fallback values explicitly, but I haven't bothered to increase API surface for that.
set_srgb
was inconsistent withset_source_gamma/chromaticities
, so this change is backwards compatible.