Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate DXT support #1654

Merged
merged 3 commits into from
Jan 16, 2022
Merged

Deprecate DXT support #1654

merged 3 commits into from
Jan 16, 2022

Conversation

fintelia
Copy link
Contributor

#1623 describes the motivation:

Right now our GPU compressed texture handling is really not all that great. For decoding we don't support any of the newer formats like BC6, BC7 or ASTC, And for encoding, our code is slow, low quality, and doesn't support any of the newer formats.

As a result, pretty much any use of the module would be better served by squish-rs which implements faster and higher quality encoding (though be sure to use 2.0.0-beta1 or later to get the recent bugfixes).

Additionally, unlike the other codecs, DXT is not actually an image file format but rather a compression format. This distinction matters for instance because it means that the DxtDecoder::new() has to be passed the image metadata unlike all our other decoders which don't need that. My suggestion is to just completely deprecate (and eventually remove) the codecs::dxt module. We can still keep the codecs::dds by porting it to rely on squish-rs instead.

Copy link
Member

@HeroicKatora HeroicKatora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should propose the known alternative directly in the notice as well.

src/lib.rs Outdated Show resolved Hide resolved
fintelia and others added 2 commits January 16, 2022 15:01
Co-authored-by: HeroicKatora <HeroicKatora@users.noreply.github.com>
@fintelia fintelia merged commit 9d70ecf into image-rs:master Jan 16, 2022
@fintelia fintelia deleted the deprecate-dxt branch August 25, 2023 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants