Perform MSRV check via -Zminimal-versions
#2121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
commented
Jan 31, 2024
| @@ -48,9 +48,13 @@ jobs: | |||
| uses: Swatinem/rust-cache@v2 | |||
| with: | |||
| cache-on-failure: true | |||
| - name: Install MSRV Cargo.lock | |||
There was a problem hiding this comment.
Note that YAML indentation is also "wrong" here 😅
fintelia
approved these changes
Jan 31, 2024
|
Note that I didn't go as far as checking if certain version bounds could actually be lower while still compiling successfully... Don't think that's particularly interesting :) |
|
Great work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2120