Add support for scanning QR codes #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torrao
force-pushed
the
master
branch
28 times, most recently
from
c2ec236
to
d28ac26
Compare
torrao
force-pushed
the
master
branch
7 times, most recently
from
0d193b1
to
b8bb2ee
Compare
| /** | ||
| The stored meta data output; used to detect QR codes. | ||
| */ | ||
| private var qrOutput: AVCaptureOutput? = nil |
There was a problem hiding this comment.
@phlippieb it seems that qrOutput is always nil. Could it be that in line 815 it should be qrOutput instead of output?
Right now there is an issue when you call stopQRCodeDetection() directly in the handler and then startQRCodeDetection(). By starting QR code detection the following times, it will not work again
There was a problem hiding this comment.
This was so long ago, I have no idea anymore 😁 it's totally possible. Is your issue fixed if you change line 815 to qrOutput?
There was a problem hiding this comment.
@phlippieb I fixed it in PR #237. Please check it out :-)
There was a problem hiding this comment.
This isn't my repo 😺
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably not quite how you would have done it, but this is something we added for our own use, and I figured let's propose this as functionality on this great project 😄