Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create navigation module #202

Merged
merged 4 commits into from
Nov 17, 2024
Merged

Create navigation module #202

merged 4 commits into from
Nov 17, 2024

Conversation

boswelja
Copy link
Collaborator

Pulling navigation components into their own module

Summary of changes:

  1. Snuck in rslash -> social module change
  2. Created navigation module
  3. Refactored NavigationBar to new module
  4. Refactored top-level destinations to new module

Tested changes:

App builds and navigation works

@boswelja boswelja self-assigned this Nov 14, 2024
import kotlinx.serialization.Serializable

@Serializable
data class ProfileRoute(
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if I'm a fan of this, but it suddenly becomes a bigger refactor to not have it here

@imashnake0 imashnake0 added the enhancement Enhancement label Nov 17, 2024
@imashnake0
Copy link
Owner

ty<3

@imashnake0 imashnake0 merged commit e2e84e1 into main Nov 17, 2024
1 check passed
@boswelja boswelja deleted the create-navigation-module branch November 17, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants