Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Pastelize with MaterialKolor APIs #230

Merged
merged 3 commits into from
Dec 28, 2024
Merged

Replace Pastelize with MaterialKolor APIs #230

merged 3 commits into from
Dec 28, 2024
+46 −120

Conversation

imashnake0
Copy link
Owner

@imashnake0 imashnake0 commented Dec 28, 2024 •
edited
Loading

MaterialKolor provides some nice APIs so we don't need to apply alphas and pastelize.

Summary of changes:

  1. Replaced in-house methods with MaterialKolor APIs.
  2. Removed alpha on cards, blended it with the background instead.

Tested changes:

brah

@imashnake0 imashnake0 added the enhancement Enhancement label Dec 28, 2024
@imashnake0 imashnake0 self-assigned this Dec 28, 2024
@imashnake0 imashnake0 changed the title Remove Pastelize with MaterialKolor APIs Replace Pastelize with MaterialKolor APIs Dec 28, 2024
@imashnake0 imashnake0 requested a review from boswelja December 28, 2024 02:53
@imashnake0 imashnake0 merged commit 0e4df88 into main Dec 28, 2024
1 check passed
@imashnake0
Copy link
Owner Author

Light

Before After
image image

Dark

Before After
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boswelja boswelja Awaiting requested review from boswelja

Assignees

@imashnake0 imashnake0

Labels
enhancement Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@imashnake0