Refactor to support feature modules #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do not merge, we need Appyx first (I can't block it) |
|
Draft it? |
|
I don't have a draft button, if you can please do |
# Conflicts: # app/src/main/java/com/imashnake/animite/features/media/MediaPage.kt # core/src/main/kotlin/com/imashnake/animite/core/extensions/StringExt.kt
|
Let's spend some more time thinking about this, ideally we'll have moved stuff to where they belong before merging. |
|
I have, except Home which needs some more prep work |
# Conflicts: # app/src/main/java/com/imashnake/animite/features/MainActivity.kt # app/src/main/java/com/imashnake/animite/features/home/Home.kt
Iannnr
reviewed
Nov 15, 2022
Iannnr
reviewed
Nov 15, 2022
core/src/main/kotlin/com/imashnake/animite/core/ui/ProgressIndicator.kt
Outdated
Show resolved
Hide resolved
Iannnr
reviewed
Nov 16, 2022
Iannnr
reviewed
Nov 16, 2022
core/src/main/kotlin/com/imashnake/animite/core/extensions/ModifierExt.kt
Show resolved
Hide resolved
Iannnr
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CONTRIBUTING.md.With this, the necessary changes have been made that were blocking feature modules (except for navigation). Once merged, we are free to write code in new modules (except navigation stuff).
Summary of changes:
com.android.libraryas a plugin.com.android.applicationto be less confusing.profileandrslash.coremodule.Tested changes:
The app still runs.