Clean up MediaPage
#70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Iannnr
reviewed
Nov 22, 2022
app/src/main/java/com/imashnake/animite/features/media/MediaPageViewModel.kt
Show resolved
Hide resolved
app/src/main/java/com/imashnake/animite/features/media/MediaPageViewModel.kt
Show resolved
Hide resolved
app/src/main/java/com/imashnake/animite/features/media/MediaPageViewModel.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/imashnake/animite/features/media/MediaPageViewModel.kt
Show resolved
Hide resolved
app/src/main/java/com/imashnake/animite/features/media/MediaPageViewModel.kt
Show resolved
Hide resolved
imashnake0
requested changes
Nov 28, 2022
core/src/main/kotlin/com/imashnake/animite/core/ui/ScrollableText.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/com/imashnake/animite/core/extensions/ListExt.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/imashnake/animite/features/media/MediaPageViewModel.kt
Show resolved
Hide resolved
app/src/main/java/com/imashnake/animite/features/media/MediaPageViewModel.kt
Show resolved
Hide resolved
app/src/main/java/com/imashnake/animite/features/media/MediaPage.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/imashnake/animite/features/media/MediaPage.kt
Outdated
Show resolved
Hide resolved
We won't need to do this once the UI gets non-null values. Co-Authored-By: Ian Roberts <9267347+Iannnr@users.noreply.github.com>
imashnake0
approved these changes
Dec 1, 2022
Looks like the API returns an empty list sometimes (?). See Dr. STONE: NEW WORLD.
|
@boswelja Fixed some edge cases and cleaned stuff up. LMK if the commits look good so I can merge. |
Added banner parallax.
The rows went under the opaque status bar in landscape mode.
|
Added parallax and fixed padding in landscape mode:
|
boswelja
commented
Dec 1, 2022
core/src/main/kotlin/com/imashnake/animite/core/extensions/ModifierExt.kt
Outdated
Show resolved
Hide resolved
boswelja
commented
Dec 1, 2022
|
Thanks @boswelja! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CONTRIBUTING.md.MediaPage does not look very tidy, and is even less enjoyable to read.
Summary of changes:
Tested changes:
MediaPage still launches & no content is missing