Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re: SearchFrontDrop #77

Merged
merged 52 commits into from
Jan 14, 2023
Merged

Re: SearchFrontDrop #77

merged 52 commits into from
Jan 14, 2023

Conversation

imashnake0
Copy link
Owner

@imashnake0 imashnake0 commented Dec 23, 2022 •
edited
Loading

All new SearchFrontDrop. Fixes #63 and #42.

Summary of changes:

  1. Cleaned up SearchViewModel.
  2. Created TextField, IconButton, and Icon components.
  3. Added previews for the new components.
  4. Created a new SearchFrontDrop.
  5. Created FrontDrop.
  6. Fixed inset padding.
  7. Fixed typography.
  8. Handled back press.

Tested changes:

The.

@imashnake0 imashnake0 added enhancement Enhancement feature New feature labels Dec 23, 2022
@imashnake0 imashnake0 requested a review from boswelja December 23, 2022 05:54
@imashnake0 imashnake0 self-assigned this Dec 23, 2022
imashnake0 and others added 2 commits December 25, 2022 03:03
@imashnake0
Prevent recomposition
977cd35 
TODO: The padding condition still causes recomposition.
@imashnake0 @danielesegato
Used consumeWindowInsets()
d4b2107 
Been stuck on this for literal weeks before @danielesegato suggested `consumeWindowInsets()`.

Co-Authored-By: Daniele Segato <469948+danielesegato@users.noreply.github.com>
@imashnake0
Copy link
Owner Author

screen-20221225-0540432.mp4

@imashnake0 imashnake0 linked an issue Jan 4, 2023 that may be closed by this pull request
Jittery keyboard launch #42
Closed
@imashnake0 imashnake0 requested review from Iannnr and boswelja and removed request for Iannnr January 4, 2023 17:11
Iannnr
Iannnr reviewed Jan 5, 2023
View reviewed changes
app/src/main/java/com/imashnake/animite/features/searchbar/SearchFrontDrop.kt Outdated Show resolved Hide resolved
app/src/main/java/com/imashnake/animite/features/searchbar/SearchFrontDrop.kt Outdated Show resolved Hide resolved
app/src/main/java/com/imashnake/animite/features/searchbar/SearchFrontDrop.kt Outdated Show resolved Hide resolved
app/src/main/java/com/imashnake/animite/features/searchbar/SearchViewModel.kt Outdated Show resolved Hide resolved
app/src/main/java/com/imashnake/animite/features/searchbar/SearchViewModel.kt Outdated Show resolved Hide resolved
app/src/main/java/com/imashnake/animite/features/searchbar/SearchViewModel.kt Outdated Show resolved Hide resolved
app/src/main/java/com/imashnake/animite/features/searchbar/SearchFrontDrop.kt Show resolved Hide resolved
app/src/main/java/com/imashnake/animite/features/searchbar/SearchFrontDrop.kt Outdated Show resolved Hide resolved
app/src/main/java/com/imashnake/animite/features/searchbar/SearchViewModel.kt Outdated Show resolved Hide resolved
app/src/main/java/com/imashnake/animite/features/searchbar/SearchFrontDrop.kt Show resolved Hide resolved
@imashnake0
Stopped requests for null or empty queries
0c7bdee 
Requests are made even when the query is null or empty, this doesn't need to happen since we would want the list to empty in both cases, try it out [here](https://anilist.co/graphiql?operationName=Search&query=query%20Search(%0A%20%20%20%20%24type%3A%20MediaType%2C%0A%20%20%20%20%24perPage%3A%20Int%20%3D%200%2C%0A%20%20%20%20%24search%3A%20String%20%3D%20%22%22%20%23%20Try%20null%0A)%20%7B%0A%20%20%20%20page%3A%20Page%20(%0A%20%20%20%20%20%20%20%20page%3A%200%2C%0A%20%20%20%20%20%20%20%20perPage%3A%20%24perPage%0A%20%20%20%20)%20%7B%0A%20%20%20%20%20%20%20%20media(%0A%20%20%20%20%20%20%20%20%20%20%20%20type%3A%20%24type%2C%0A%20%20%20%20%20%20%20%20%20%20%20%20sort%3A%20%5BPOPULARITY_DESC%5D%2C%0A%20%20%20%20%20%20%20%20%20%20%20%20search%3A%20%24search%0A%20%20%20%20%20%20%20%20)%20%7B%20%0A%20%20%20%20%20%09%09%09id%0A%20%20%20%20%20%20%09%09title%20%7B%0A%09%09%09%09%09%09romaji%0A%20%20%20%20%20%20%20%20%20%20%7D%0A%20%20%20%20%09%09%7D%0A%20%20%20%20%7D%0A%7D).
@imashnake0
Fixed search icon
2950281 
- Imported a new drawable that's 24 x 24 and not 20 x 21 or something.
- Removed component.
- Removed redundant size modifier.
@imashnake0
Use let instead of if when it is complex/mutable
9026cdd
@imashnake0
Removed IconButton wrapper
4a158b6
@imashnake0
Removed TextField wrapper
f533a4a 
- Removed wrapper.
- Added a baseline shift since manrope is not vertically center aligned by default.
@imashnake0
Hardcoded strings make Jack ill
234661c
@imashnake0
Use plural resources
aca8fbb
@imashnake0 imashnake0 requested review from boswelja and Iannnr January 8, 2023 20:53
@imashnake0
Copy link
Owner Author

Screenshot_20230108-160208.png

@imashnake0
if is more readable
1f872dd
@imashnake0
Fixed glitch
7efb687 
There was a strange glitch that I observed on Pixel 6a where the keyboard briefly shows up even after being dismissed.
@imashnake0
Copy link
Owner Author

Alright, looks like I addressed most of the issues. Thank you for the reviews! @boswelja @Iannnr <3

@imashnake0 imashnake0 merged commit 1766500 into main Jan 14, 2023
@imashnake0 imashnake0 deleted the fix-search-list-re branch January 14, 2023 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boswelja boswelja Awaiting requested review from boswelja

@Iannnr Iannnr Awaiting requested review from Iannnr

Assignees

@imashnake0 imashnake0

Labels
enhancement Enhancement feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Search list goes beyond the screen Jittery keyboard launch
3 participants
@imashnake0 @Iannnr @boswelja