This repository has been archived by the owner on May 22, 2024. It is now read-only.
feat: ✨ accept joins only from allowed users #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarHarLinks
changed the title
prevents an exploit where an unauthorized user invites an already joined bot to make it leave
HarHarLinks
commented
Aug 20, 2022
| joined_rooms = await self.async_client.joined_rooms() | ||
| if room.room_id not in joined_rooms.rooms: | ||
| # prevents leaving if already in the room opposed to rejecting invites | ||
| await self.async_client.room_leave(room.room_id) |
There was a problem hiding this comment.
An open question is whether actively rejecting, hence giving the inviter feedback and blocking further invites, is better than simply ignoring invites.
There was a problem hiding this comment.
I think we should ignore by default, but provide a config setting to allow rejection.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.