Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid running on a comment page #21

Closed
imdj opened this issue Feb 6, 2024 · 0 comments
Closed

Avoid running on a comment page #21

imdj opened this issue Feb 6, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@imdj
Copy link
Owner

imdj commented Feb 6, 2024

Submissions and comments on Hacker News share the same URL format:

  • Submissions: /item?id=38309611
  • Comments: /item?id=38310213

Right now, the extension relies solely on the manifest's content_scripts key and runs on any page it's allowed on, i.e: pages that matches *://news.ycombinator.com/item*
We have to implement some safety rail to detect submission pages and further limit execution
@imdj imdj added the bug Something isn't working label Feb 6, 2024
imdj added a commit that referenced this issue Feb 6, 2024
@imdj
Fix: avoid running on a comment page. Issue #21
a7dc95b
@imdj imdj closed this as completed Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@imdj