fix: set domain as optional

imgix · Feb 6, 2023 · 99310b1 · 99310b1
1 parent 35df3b9
commit 99310b1
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 11 deletions.
diff --git a/src/modules/gatsby-plugin/pluginOptionsSchema.ts b/src/modules/gatsby-plugin/pluginOptionsSchema.ts
@@ -72,7 +72,7 @@ export const pluginOptionsSchema: NonNullable<
 
   const schema = Joi.object<IImgixGatsbyOptions & { plugins: any }>().keys({
     domain: Joi.string()
-      .required()
+      .optional()
       .description(
         "This is the domain of your imgix source, which can be created at https://dashboard.imgix.com/. The source specified must be a 'Web Proxy' source type.",
       ),

diff --git a/test/unit/pluginHelpers.test.ts b/test/unit/pluginHelpers.test.ts
@@ -1,18 +1,21 @@
 import * as fetchImgixMetadataModule from '../../src/api/fetchImgixMetadata';
+import { createImgixUrlSchemaFieldConfig } from '../../src/modules/gatsby-plugin/createImgixUrlFieldConfig';
 import { createImgixGatsbyTypes } from '../../src/pluginHelpers';
 
-// test('should be able to call createImgixUrlFieldConfig with no domain and resolve a url', async () => {
-//   const config = createImgixUrlSchemaFieldConfig({
-//     resolveUrl: (node) => (node as any).url,
-//   });
+test('should be able to call createImgixUrlFieldConfig with no domain and resolve a url', async () => {
+  const config = createImgixUrlSchemaFieldConfig({
+    imgixClientOptions: { domain: '' },
+    resolveUrl: () => 'https://assets.imgix.net/amsterdam.jpg',
+    paramsInputType: '',
+  });
 
-//   const resolved = await (config as any).resolve(
-//     { url: 'https://assets.imgix.net/amsterdam.jpg' },
-//     {},
-//   );
+  const resolved = await (config as any).resolve(
+    { url: 'https://assets.imgix.net/amsterdam.jpg' },
+    {},
+  );
 
-//   expect(resolved).toMatch(/^https:\/\/assets.imgix.net\/amsterdam.jpg\?/);
-// });
+  expect(resolved).toMatch(/^https:\/\/assets.imgix.net\/amsterdam.jpg\?/);
+});
 // test('should be able to call createImgixUrlFieldConfig with a domain and resolve a url', async () => {
 //   const config = createImgixUrlSchemaFieldConfig({
 //     resolveUrl: (node) => (node as any).url,