chore: remove deprecated domain sharding behavior #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jayeb Now that I think about it, perhaps we don't actually want to remove support for multiple sources so long as they don't rely on domain sharding to cycle through them? Or else users will be stuck with only configuring a single source on their app. |
|
Agreed, let's keep multi-source support while removing sharding. |
sherwinski
changed the title
jayeb
approved these changes
Nov 5, 2019
sherwinski
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes support for domain sharding an array of source domains. Domain sharding was deprecated/removed from imgix-rb in v3.0.0, which will have to be removed from this gem as well.