Optimise Imgix::Path#to_url by not generating the escaped query string twice #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Output: ``` ❯ bundle exec ruby script/bench_to_url.rb Warming up -------------------------------------- Imgix::Path#to_url 1.683k i/100ms Calculating ------------------------------------- Imgix::Path#to_url 16.886k (± 0.6%) i/s - 85.833k in 5.083431s ```
Tests
Performance Improvements
ContributorsCommit-Lint commandsYou can trigger Commit-Lint actions by commenting on this PR:
|
Benchmark output: ``` ❯ bundle exec ruby script/bench_to_url.rb Warming up -------------------------------------- Imgix::Path#to_url 2.731k i/100ms Calculating ------------------------------------- Imgix::Path#to_url 27.278k (± 0.7%) i/s - 136.550k in 5.006213s ```
stevehodgkiss
force-pushed
the
optimise_to_url
branch
from
6b38dad
to
4d0891f
Compare
|
Hey there @stevehodgkiss thanks for the PR! I've pinged someone on our team with more extensive knowledge of this library than me to take a look at this, and hopefully we can get this merged in soon! |
7 tasks
|
@stevehodgkiss Nice! At a glance, I like this a lot. I'm currently working on performance improvements in our codebase and deferring computation until it's needed is a technique I use often (it often helps to de-duplicate computation). I will review this more thoroughly later today/tomorrow. Thanks for this! |
sherwinski
approved these changes
Apr 7, 2021
There was a problem hiding this comment.
Thanks for the PR @stevehodgkiss, this seems like a straightforward boost to me 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In profiling an application that renders a lot of Imgix images, I noticed a significant amount of time spent escaping the query string in
Imgix::Path#query.To generate a URL,
Imgix::Path#queryis called twice - once for the URL to be rendered, and again to generate the signature.The change in this PR avoids generating the escaped query string twice, and almost doubles the performance of
to_urlon my machine.Before:
After: