build: update to support Swift 5 #17
Conversation
|
Hi @ikait thanks for the PR. Just wanting to be sure, how will this affect our users who might be using older versions of XCode and/or Swift? |
|
Hi @sherwinski. Swift 5 isn’t compatible (cannot build) with older versions of Xcode and Swift. After merge this, I suppose it would be better to make and publish a new tag like 0.5.0 and add comments like "The imgix Swift client is compatible with Swift 5.0" for users who use older versions just like https://github.com/imgix/imgix-swift/blob/master/README.md#swift |
|
Hi @ikait, that makes sense. I tried to search around and see how other swift projects handle multiple swift/xcode versions but wasn't able to find a concrete practice. |
|
Hi @sherwinski, thanks for reply. Removed. |
|
@sherwinski any updates for this PR ? |
|
Hi @fumito-ito thanks for following up. My biggest hesitation for merging this PR right now is whether it will prevent us from being able to release features for our users who are still on swift version 4. Additionally, if I had some way of understanding how many swift developers out there are still using swift 4 versus how quickly they are upgrading to swift 5, it would help a lot in deciding when we should upgrade as well. |
|
Hi @sherwinski , Xcode 11.X has been released and I suppose almost iOS projects have already developed by using Swift 5 so I think it's time to merge this branch. Thanks. |
|
Hi @ikait! I think you are correct and after looking around at a few popular libraries online (e.g. Alamofire, Perfect, SwiftLint, Eureka, Moya, RxSwift, SnapKit) it seems like there has been wide adoption of Swift 5. I am comfortable with merging this now. Thank you for putting in the work for this @ikait 🙌 |
Changes with this PR make build available with Xcode 10.2 and Swift 5.