refactor: use Swift CommonCrypto module to calculate md5 hashes #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 31, 2020 14:23
…ead of the equivalent ObjC library
sherwinski
commented
Jan 31, 2020
There was a problem hiding this comment.
Hello @ikait, was hoping you could give a look over these changes and see if porting over the MD5 generation to Swift in this way makes sense. I also had a separate question about Swift projects that I wasn't able to find the answer for online. Thank you!
added 2 commits
February 3, 2020 09:12
- enable nonlocalization
- enable base internalization
- migrate deprecated 'English.lproj' localization
- set macOS scheme @objc inference setting to 'default'
- upgrade iOS and tvOS schemes to swift 5
- use default architectures when testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CommonCrypto is Apple's Open Source cryptography library, which we leverage for generating our URL signature hashes. Previously, we relied on importing the C version of the library and hooking it up to generate hashes in our mostly-swift code base.
This PR refactors the library to use the Swift CommonCrypto module, which ships with XCode 10+ out of the box. This won't result in any difference in this library's behavior. However, this change will help immensely with eventually supporting this project on Swift Package Manager, which has a difficult time handling Swift + ObjC mixed codebases, as well as yielding a cleaner codebase overall. The solution to port over the MD5 function to pure swift was a suggestion from #21.