Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: draft vue 3 support #394

Closed
wants to merge 14 commits into from
Closed

feat!: draft vue 3 support #394

wants to merge 14 commits into from

Commits on Apr 20, 2021

  1. build(semanticrelease): set pre-release to next

    @luqven
    luqven committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    f5d2b2f View commit details
    Browse the repository at this point in the history

  2. chore(shims): make vue shim use defineComponent 

     Allows .vue single file components to be imported and used. Since
 the Global Vue API has been deprecated, this file needs to import
 the return type of defineComponent for TypeScript to be able to
 import and use the single file components.
    @luqven
    luqven committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    461fdf5 View commit details
    Browse the repository at this point in the history

  3. refactor: use createApp & app.use vue 3 API 

    Vue can no longer be imported from `vue`. Instead, we need to create
a vue app instance and "install" our components on the app.
    @luqven
    luqven committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    b583a39 View commit details
    Browse the repository at this point in the history

  4. build: update dependencies 

    @VUE cli-plugin-babel, cli-plugin-e2e-cypress, cli-plugin-eslint,
cli-plugin-typescrip, cli-plugin-unit-jest, cli-service, compiler-sfc
vue, vue-router, and vuex all need to be updated to support Vue 3.
    @luqven
    luqven committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    29b4fd9 View commit details
    Browse the repository at this point in the history

  5. chore: attemtp to remove Vue global calls 

    vue-class-component dependency needed to be updated to 8.0 rc1.
This version introduced new decorators, a global Vue instance, and
a `prop` method which I tried to use with varying success.
    @luqven
    luqven committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    ebe0a5e View commit details
    Browse the repository at this point in the history

  6. chore: attempt to remove vue-class-component 

    The vue-class-component docs are confusing at this time. This was
an attempt to remove this dependency. It was not successful.
    @luqven
    luqven committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    1710de7 View commit details
    Browse the repository at this point in the history

  7. chore(index): undo change from component to use 

    This commit reverts the use of `App.use`. The correct `App` instance
method to use here is `App.component`.
    @luqven
    luqven committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    d352c98 View commit details
    Browse the repository at this point in the history

  8. chore: fix vbind var and add alt attr 

    This commit addresses a typo in `buildSrcSet.vue` that resulted in an
error where `advancedSrc` was not defined in the scope of the component.
It also adds an `alt` attribute to the component, since the vue linter
was complaining about it missing.
    @luqven
    luqven committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    c501488 View commit details
    Browse the repository at this point in the history

  9. refactor(main): use createApp Vue 3 API 

    Global Vue is not available in Vue 3. This commit imports the new
`createApp` method and uses it to initialize the vue app.
    @luqven
    luqven committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    76ffcf8 View commit details
    Browse the repository at this point in the history

  10. test: update domain path to one that resolves 

    `testing.imgix` source has been disabled. This commit changes the urls
to be `assets.imgix` in the tests that used the old url.
    @luqven
    luqven committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    8120c5c View commit details
    Browse the repository at this point in the history

  11. chore(ix-img): re-introduce vue-class-comp usage 

    This commit reverts a change where vue-class-component was removed.
Instead, it makes proper use of the `prop` and `Vue` exports from that
library.
    @luqven
    luqven committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    92b8e06 View commit details
    Browse the repository at this point in the history

  12. chore(ix-picture): re-introduce vue-class-comp use

    @luqven
    luqven committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    244c540 View commit details
    Browse the repository at this point in the history

  13. chore(ix-source): re-introduce vue-class-comp use

    @luqven
    luqven committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    14d0ea0 View commit details
    Browse the repository at this point in the history

  14. docs(README): update readme for vue 3 support

    @luqven
    luqven committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    3784dc7 View commit details
    Browse the repository at this point in the history