Add disable methods (and update to imgui 1.84.2) #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Letting thom know to check if they have time. I do hilariously have the same feeling actually on negative bools -- I often write |
Previously if you checked out a different rev of imgui submodule, this would be clobbered With this change, you can checkout any revision of imgui, run bindgen, build, test, then commit change to the submodule The autofix is still available via 'cargo task modfix'
Changes required: - Overloaded methods named slightly differently (e.g sys::igPlotHistogramFloatPtr to sys::igPlotHistogram_FloatPtr) - ImGuiNavInput_KeyMenu_ was removed upstream, so NavInput::INTERNAL_COUNT needed tweaked
Also change oddly-specific test to avoid having to change it every update
|
Updated sans |
|
thank you dbr! |
|
Oh just realized the CHANGELOG needs updated to mention 1.84.2 (currently it only mentions the previous update to 1.82) |
|
@dbr good memory. will add this to the tracking issue so I don't forget, but I'll be doing over the entire changelog/readme fairly extensively before release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the interesting change is in the last commit b24b726 - rest is fairly mechanical updating to latest imgui upstream.
Although it's worth noting I did change how
cargo xtask bindgenworks, so it doesn't callcargo xtask fixmod- which @thomcc may have some opinion on? (although we should either keep this change, or change thedocs/upgrading-imgui.mddoc as the two contradict each other)For the interesting part, there is token and closure based methods to disable widgets.
I think the only bit of some contention might be: I have an
irrationalrational dislike of double-/triple-negative boolean logic in code (e.gdisabled(!false)then introduce alet not_enabled = ...😢 ), thus I've included bothenabledanddisabledmethods (similar to Qt'ssetEnabled(...)andsetDisabled(...)). Arguably a little redundant, but I think it's worthwhile to include to improve easy-of-reading