Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to resolve #686.
Instead of using the
std::mem::transmute
workaround mentioned in several issues (e.g. grovesNL/glow#187 (comment)), I resorted to using a typesafe solution until a proper mechanism is put into place.The way I recreate the GL objects from the raw
u32
handles is to directly create newglow::Native*
objects, since their inner field is public. This at least ensures that any breaking layout changes will be detected, which is not necessarily the case in thetransmute()
workaround.Of course, this makes compiling for wasm completely impossible right now, but as far as I can tell, this is not possible anyway.