Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give warning if something is returned from thunk #3

Closed
mweststrate opened this issue Dec 30, 2017 · 4 comments
Closed

Give warning if something is returned from thunk #3

mweststrate opened this issue Dec 30, 2017 · 4 comments
Milestone
1.0

Comments

@mweststrate
Copy link
Collaborator

No description provided.

Gregjarvez added a commit to Gregjarvez/immer that referenced this issue Jan 1, 2018
@Gregjarvez
Give warning if something is returned from thunk immerjs#3
8bde915
Gregjarvez added a commit to Gregjarvez/immer that referenced this issue Jan 1, 2018
@Gregjarvez
mend
12c4cae 
Give warning if something is returned from thunk immerjs#3
Gregjarvez added a commit to Gregjarvez/immer that referenced this issue Jan 1, 2018
@Gregjarvez
mend
8843dfd 
Give warning if something is returned from thunk immerjs#3
@Gregjarvez
Copy link
Contributor

Gregjarvez commented Jan 1, 2018 •
edited
Loading

Hi. I am new to contributing to open source and I am really excited about Immer. I worked on #3.
1 . I checked if something either than undefined was returned from invoking the thunk and
printed a warning as request
2. One test and function(pretty print warning) were added.

Fixes #3

@mweststrate
Copy link
Collaborator Author

See #16

@mweststrate
Copy link
Collaborator Author

Thanks a lot @Gregjarvez! Left a few comments, but looking good :)

Gregjarvez added a commit to Gregjarvez/immer that referenced this issue Jan 1, 2018
@Gregjarvez
added prettier and used typeof immerjs#3
670b013
Gregjarvez added a commit to Gregjarvez/immer that referenced this issue Jan 1, 2018
@Gregjarvez
mend
22708e6 
removed .idea immerjs#3
@mweststrate
Copy link
Collaborator Author

Released as part of 0.1.0

@mweststrate mweststrate added this to the 1.0 milestone Jan 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
2 participants
@mweststrate @Gregjarvez