Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: consistent recipe return type in produceWithPatches #934

Merged
merged 1 commit into from
May 11, 2022
Merged

fix: consistent recipe return type in produceWithPatches #934

merged 1 commit into from
May 11, 2022

Conversation

mylesj
Copy link
Contributor

@mylesj mylesj commented May 5, 2022

I believe this should be consistent with produce on lines 217 & 224 - otherwise, as a consumer of both functions I would need to double-up on my own typing to handle each separately.

@netlify
Copy link

netlify bot commented May 5, 2022

Deploy Preview for quizzical-lovelace-dcbd6a canceled.

Name Link
🔨 Latest commit 7894ba3
🔍 Latest deploy log https://app.netlify.com/sites/quizzical-lovelace-dcbd6a/deploys/62737d46c449f600082f5422

mylesj added a commit to mylesj/immer-compose that referenced this pull request May 5, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2274285932

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.553%

Totals Coverage Status
Change from base Build 2257376231: 0.0%
Covered Lines: 786
Relevant Lines: 794

💛 - Coveralls

@mweststrate
Copy link
Collaborator

I think you're right! thanks for the PR

@mweststrate mweststrate merged commit 220d61d into immerjs:master May 11, 2022
@github-actions
Copy link
Contributor

🎉 This PR is included in version 9.0.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

@coveralls
Copy link

coveralls commented Oct 22, 2024

Pull Request Test Coverage Report for Build 2274285932

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.553%

Totals Coverage Status
Change from base Build 2257376231: 0.0%
Covered Lines: 786
Relevant Lines: 794

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants