Skip to content

Commit

Permalink
feat(web): stable json settings export (#14036)
Browse files Browse the repository at this point in the history
* recursively sort json output (settings)

* fix format/lint/...g
  • Loading branch information
mcarbonne authored Nov 9, 2024
1 parent 6b49104 commit 5c31acb
Showing 1 changed file with 14 additions and 2 deletions.
16 changes: 14 additions & 2 deletions web/src/routes/admin/system-settings/+page.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,20 @@
type SettingsComponent = ComponentType<SvelteComponent<SettingsComponentProps>>;
// https://stackoverflow.com/questions/16167581/sort-object-properties-and-json-stringify/43636793#43636793
const jsonReplacer = (key: string, value: unknown) =>
value instanceof Object && !Array.isArray(value)
? Object.keys(value)
.sort()
// eslint-disable-next-line unicorn/no-array-reduce
.reduce((sorted: { [key: string]: unknown }, key) => {
sorted[key] = (value as { [key: string]: unknown })[key];
return sorted;
}, {})
: value;
const downloadConfig = () => {
const blob = new Blob([JSON.stringify(config, null, 2)], { type: 'application/json' });
const blob = new Blob([JSON.stringify(config, jsonReplacer, 2)], { type: 'application/json' });
const downloadKey = 'immich-config.json';
downloadManager.add(downloadKey, blob.size);
downloadManager.update(downloadKey, blob.size);
Expand Down Expand Up @@ -240,7 +252,7 @@
<div class="hidden lg:block">
<SearchBar placeholder={$t('search_settings')} bind:name={searchQuery} showLoadingSpinner={false} />
</div>
<LinkButton on:click={() => copyToClipboard(JSON.stringify(config, null, 2))}>
<LinkButton on:click={() => copyToClipboard(JSON.stringify(config, jsonReplacer, 2))}>
<div class="flex place-items-center gap-2 text-sm">
<Icon path={mdiContentCopy} size="18" />
{$t('copy_to_clipboard')}
Expand Down

0 comments on commit 5c31acb

Please sign in to comment.