chore(server): remove unused property

immich-app · May 15, 2024 · a5ed08c · a5ed08c
1 parent 581b467
commit a5ed08c
Show file tree

Hide file tree

Showing 17 changed files with 16 additions and 114 deletions.
diff --git a/mobile/openapi/doc/CreateLibraryDto.md b/mobile/openapi/doc/CreateLibraryDto.md
diff --git a/mobile/openapi/doc/UpdateLibraryDto.md b/mobile/openapi/doc/UpdateLibraryDto.md
diff --git a/mobile/openapi/lib/model/create_library_dto.dart b/mobile/openapi/lib/model/create_library_dto.dart
diff --git a/mobile/openapi/lib/model/update_library_dto.dart b/mobile/openapi/lib/model/update_library_dto.dart
diff --git a/mobile/openapi/test/create_library_dto_test.dart b/mobile/openapi/test/create_library_dto_test.dart
diff --git a/mobile/openapi/test/update_library_dto_test.dart b/mobile/openapi/test/update_library_dto_test.dart
diff --git a/open-api/immich-openapi-specs.json b/open-api/immich-openapi-specs.json
@@ -7708,9 +7708,6 @@
             },
             "type": "array"
           },
-          "isVisible": {
-            "type": "boolean"
-          },
           "name": {
             "type": "string"
           },
@@ -10741,9 +10738,6 @@
             },
             "type": "array"
           },
-          "isVisible": {
-            "type": "boolean"
-          },
           "name": {
             "type": "string"
           }

diff --git a/open-api/typescript-sdk/src/fetch-client.ts b/open-api/typescript-sdk/src/fetch-client.ts
@@ -442,15 +442,13 @@ export type LibraryResponseDto = {
 export type CreateLibraryDto = {
     exclusionPatterns?: string[];
     importPaths?: string[];
-    isVisible?: boolean;
     name?: string;
     ownerId: string;
     "type": LibraryType;
 };
 export type UpdateLibraryDto = {
     exclusionPatterns?: string[];
     importPaths?: string[];
-    isVisible?: boolean;
     name?: string;
 };
 export type ScanLibraryDto = {

diff --git a/server/src/cores/user.core.ts b/server/src/cores/user.core.ts
@@ -101,7 +101,6 @@ export class UserCore {
       type: LibraryType.UPLOAD,
       importPaths: [],
       exclusionPatterns: [],
-      isVisible: true,
     });
 
     return userEntity;

diff --git a/server/src/dtos/library.dto.ts b/server/src/dtos/library.dto.ts
@@ -16,9 +16,6 @@ export class CreateLibraryDto {
   @IsNotEmpty()
   name?: string;
 
-  @ValidateBoolean({ optional: true })
-  isVisible?: boolean;
-
   @Optional()
   @IsString({ each: true })
   @IsNotEmpty({ each: true })
@@ -40,9 +37,6 @@ export class UpdateLibraryDto {
   @IsNotEmpty()
   name?: string;
 
-  @ValidateBoolean({ optional: true })
-  isVisible?: boolean;
-
   @Optional()
   @IsString({ each: true })
   @IsNotEmpty({ each: true })

diff --git a/server/src/entities/library.entity.ts b/server/src/entities/library.entity.ts
@@ -50,9 +50,6 @@ export class LibraryEntity {
 
   @Column({ type: 'timestamptz', nullable: true })
   refreshedAt!: Date | null;
-
-  @Column({ type: 'boolean', default: true })
-  isVisible!: boolean;
 }
 
 export enum LibraryType {

diff --git a/server/src/migrations/1715798702876-RemoveLibraryIsVisible.ts b/server/src/migrations/1715798702876-RemoveLibraryIsVisible.ts
@@ -0,0 +1,14 @@
+import { MigrationInterface, QueryRunner } from "typeorm";
+
+export class RemoveLibraryIsVisible1715798702876 implements MigrationInterface {
+    name = 'RemoveLibraryIsVisible1715798702876'
+
+    public async up(queryRunner: QueryRunner): Promise<void> {
+        await queryRunner.query(`ALTER TABLE "libraries" DROP COLUMN "isVisible"`);
+    }
+
+    public async down(queryRunner: QueryRunner): Promise<void> {
+        await queryRunner.query(`ALTER TABLE "libraries" ADD "isVisible" boolean NOT NULL DEFAULT true`);
+    }
+
+}
diff --git a/server/src/repositories/library.repository.ts b/server/src/repositories/library.repository.ts
@@ -67,7 +67,6 @@ export class LibraryRepository implements ILibraryRepository {
     return this.repository.find({
       where: {
         ownerId,
-        isVisible: true,
         type,
       },
       relations: {
@@ -97,7 +96,6 @@ export class LibraryRepository implements ILibraryRepository {
   getAllDeleted(): Promise<LibraryEntity[]> {
     return this.repository.find({
       where: {
-        isVisible: true,
         deletedAt: Not(IsNull()),
       },
       relations: {

diff --git a/server/src/services/asset-v1.service.ts b/server/src/services/asset-v1.service.ts
@@ -259,7 +259,6 @@ export class AssetServiceV1 {
         type: LibraryType.UPLOAD,
         importPaths: [],
         exclusionPatterns: [],
-        isVisible: true,
       });
     }
 

diff --git a/server/src/services/library.service.spec.ts b/server/src/services/library.service.spec.ts
@@ -830,7 +830,6 @@ describe(LibraryService.name, () => {
             type: LibraryType.EXTERNAL,
             importPaths: [],
             exclusionPatterns: [],
-            isVisible: true,
           }),
         );
       });
@@ -860,37 +859,6 @@ describe(LibraryService.name, () => {
             type: LibraryType.EXTERNAL,
             importPaths: [],
             exclusionPatterns: [],
-            isVisible: true,
-          }),
-        );
-      });
-
-      it('should create invisible', async () => {
-        libraryMock.create.mockResolvedValue(libraryStub.externalLibrary1);
-        await expect(
-          sut.create({ ownerId: authStub.admin.user.id, type: LibraryType.EXTERNAL, isVisible: false }),
-        ).resolves.toEqual(
-          expect.objectContaining({
-            id: libraryStub.externalLibrary1.id,
-            type: LibraryType.EXTERNAL,
-            name: libraryStub.externalLibrary1.name,
-            ownerId: libraryStub.externalLibrary1.ownerId,
-            assetCount: 0,
-            importPaths: [],
-            exclusionPatterns: [],
-            createdAt: libraryStub.externalLibrary1.createdAt,
-            updatedAt: libraryStub.externalLibrary1.updatedAt,
-            refreshedAt: null,
-          }),
-        );
-
-        expect(libraryMock.create).toHaveBeenCalledWith(
-          expect.objectContaining({
-            name: expect.any(String),
-            type: LibraryType.EXTERNAL,
-            importPaths: [],
-            exclusionPatterns: [],
-            isVisible: false,
           }),
         );
       });
@@ -924,7 +892,6 @@ describe(LibraryService.name, () => {
             type: LibraryType.EXTERNAL,
             importPaths: ['/data/images', '/data/videos'],
             exclusionPatterns: [],
-            isVisible: true,
           }),
         );
       });
@@ -972,7 +939,6 @@ describe(LibraryService.name, () => {
             type: LibraryType.EXTERNAL,
             importPaths: [],
             exclusionPatterns: ['*.tmp', '*.bak'],
-            isVisible: true,
           }),
         );
       });
@@ -1002,7 +968,6 @@ describe(LibraryService.name, () => {
             type: LibraryType.UPLOAD,
             importPaths: [],
             exclusionPatterns: [],
-            isVisible: true,
           }),
         );
       });
@@ -1032,7 +997,6 @@ describe(LibraryService.name, () => {
             type: LibraryType.UPLOAD,
             importPaths: [],
             exclusionPatterns: [],
-            isVisible: true,
           }),
         );
       });

diff --git a/server/src/services/library.service.ts b/server/src/services/library.service.ts
@@ -271,7 +271,6 @@ export class LibraryService {
       type: dto.type,
       importPaths: dto.importPaths ?? [],
       exclusionPatterns: dto.exclusionPatterns ?? [],
-      isVisible: dto.isVisible ?? true,
     });
 
     this.logger.log(`Creating ${dto.type} library for ${dto.ownerId}}`);