Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mobile): upgrade maplibre_gl package to fix issue with crash in ios7.4 above simulator #10182

Merged
merged 3 commits into from
Jun 17, 2024
Merged

fix(mobile): upgrade maplibre_gl package to fix issue with crash in ios7.4 above simulator #10182

merged 3 commits into from
Jun 17, 2024

Conversation

Mujhtech
Copy link
Contributor

@Mujhtech Mujhtech commented Jun 12, 2024 •
edited
Loading

Description

  • On tap on Search tab in bottom navigation, app crashes on iOS17.4 above simulator
  • On clicking on View all in Search page for places, null check error is displayed instead of list widget

Fixes # (issue)

  • Migrated to the latest maplibre_gl sdk resolve the crash issue
  • Perform a null check on exifInfo and city otherwise, set label to empty

How Has This Been Tested?

  • Test A
  • Test B

Screenshots (if appropriate):

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable

@Mujhtech Mujhtech changed the title Fix/upgrade maplibre gl fix(mobile): upgrade maplibre_gl package to fix issue with crash in ios7.4 above simulator Jun 12, 2024
@alextran1502 alextran1502 enabled auto-merge (squash) June 17, 2024 22:22
@alextran1502 alextran1502 merged commit 99c6fdb into immich-app:main Jun 17, 2024
22 checks passed
alextran1502 added a commit that referenced this pull request Jul 2, 2024
@alextran1502
Revert "fix(mobile): upgrade maplibre_gl package to fix issue with cr…
ad630c0 
…ash in ios7.4 above simulator (#10182)"

This reverts commit 99c6fdb.
alextran1502 added a commit that referenced this pull request Jul 2, 2024
@alextran1502
fix(mobile): map crashes on Android (#10773)
f23401d 
Revert "fix(mobile): upgrade maplibre_gl package to fix issue with crash in ios7.4 above simulator (#10182)"

This reverts commit 99c6fdb.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alextran1502 alextran1502 alextran1502 approved these changes

Assignees
No one assigned
Labels
📱mobile
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mujhtech @alextran1502