Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): Update prompt #10237

Merged
merged 6 commits into from
Jun 17, 2024
Merged

fix(web): Update prompt #10237

merged 6 commits into from
Jun 17, 2024

Conversation

aviv926
Copy link
Contributor

@aviv926 aviv926 commented Jun 12, 2024

Add information about irreversible action when merging people to the prompt

@aviv926 aviv926 changed the title web: Update prompt fix (web): Update prompt Jun 12, 2024
@aviv926 aviv926 changed the title fix (web): Update prompt fix(web): Update prompt Jun 12, 2024
Copy link
Contributor

@alextran1502 alextran1502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you help make this into a translatable string as well? Thanks!

@aviv926
Copy link
Contributor Author

aviv926 commented Jun 13, 2024

Can you help make this into a translatable string as well? Thanks!

Can you help make this into a translatable string as well? Thanks!

I have updated.
I also tried to do
message: Merged ${count} ${count === 1 ? 'person' : 'people'},

But I didn't really succeed, so I left it as a source

@alextran1502 alextran1502 merged commit c1a5ed3 into immich-app:main Jun 17, 2024
22 checks passed
@aviv926 aviv926 deleted the update-prompt branch June 21, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants