Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(web): another missing translations #10274

Merged
merged 57 commits into from
Jun 24, 2024
Merged

chore(web): another missing translations #10274

merged 57 commits into from
Jun 24, 2024

Conversation

waclaw66
Copy link
Contributor

Add another missing translations.

@waclaw66 waclaw66 marked this pull request as draft June 13, 2024 12:48
@waclaw66 waclaw66 marked this pull request as ready for review June 14, 2024 11:02
jrasm91
jrasm91 requested changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO every translation usage should use this format $t('string_key_value'). Please don't dynamically translate variables and please always follow this syntax. If it isn't in a svelte component then you can do this const $t = get(t); and then $t('string_key_value').

@waclaw66
Copy link
Contributor Author

IMO every translation usage should use this format $t('string_key_value'). Please don't dynamically translate variables and please always follow this syntax. If it isn't in a svelte component then you can do this const $t = get(t); and then $t('string_key_value').

const $t = get(t); can be used for async functions but it doesn't work within export const

jrasm91
jrasm91 reviewed Jun 14, 2024
View reviewed changes
Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks a lot better, thanks!

web/src/lib/utils.ts Outdated Show resolved Hide resolved
web/src/routes/auth/login/+page.ts Outdated Show resolved Hide resolved
@waclaw66 @michelheusschen
Update web/src/lib/i18n/en.json
3757636 
Co-authored-by: Michel Heusschen <59014050+michelheusschen@users.noreply.github.com>
@waclaw66 waclaw66 requested a review from danieldietzler as a code owner June 16, 2024 07:20
@github-actions github-actions bot added documentation Improvements or additions to documentation 📱mobile 🗄️server labels Jun 16, 2024
michelheusschen
michelheusschen approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@michelheusschen michelheusschen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the effort!

@waclaw66
Copy link
Contributor Author

Thanks a lot for the effort!

Happy to contribute.

@michelheusschen michelheusschen removed documentation Improvements or additions to documentation 📱mobile 🗄️server labels Jun 18, 2024
@jrasm91 jrasm91 merged commit dd2c740 into immich-app:main Jun 24, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michelheusschen michelheusschen michelheusschen approved these changes

@jrasm91 jrasm91 jrasm91 approved these changes

@danieldietzler danieldietzler Awaiting requested review from danieldietzler

Assignees
No one assigned
Labels
changelog:translation 🖥️web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@waclaw66 @jrasm91 @michelheusschen