chore(web): standardize settings labels #10303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- spelling out "max" and "min" in full - accordions use title case - labels for settings all use sentence case - remove the "Enable"/"Enabled"/"ENABLED" titles for toggles, in favor of just using the description - change any gray labels to be immich blue, to match the look and feel of the other settings
…e/standardize-settings
jrasm91
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating the admin settings to have consistent casing, colors, and labeling. This makes the admin settings look consistent to how the account settings look today.
Summary of the new conventions:
of just using the description. I think this is easier to understand, and makes more sense when navigating the settings with a screen reader.
Other changes:
Screenshots
Example toggle