Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): full screen view for duplicates #10346

Merged
merged 2 commits into from
Jun 15, 2024

Conversation

michelheusschen
Copy link
Contributor

Adds a button to view duplicate assets in full screen. Also changed:

  • Use relative units instead of pixels
  • More descriptive buttons for permanent delete confirmation

Preview where the left button opens the asset viewer
image

Closes #10173

Copy link
Member

@danieldietzler danieldietzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great to me!

@@ -317,6 +317,7 @@
"archived": "Archived",
"asset_offline": "Asset offline",
"assets": "Assets",
"assets_moved_to_trash": "Moved {count, plural, one {# asset} other {# assets}} to trash",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does # work similar to {count, number}?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes exactly, we're already using the shorter # syntax for some of our existing translations

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok, that's cool (and easier)! :D

Copy link
Contributor

@alextran1502 alextran1502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much!

@alextran1502 alextran1502 enabled auto-merge (squash) June 15, 2024 20:40
@alextran1502 alextran1502 merged commit f3c15c7 into main Jun 15, 2024
22 checks passed
@alextran1502 alextran1502 deleted the feat/web-fullscreen-duplicates branch June 15, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants