Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): bulk deduplicate #10448

Merged
merged 7 commits into from
Jun 19, 2024
Merged

feat(web): bulk deduplicate #10448

merged 7 commits into from
Jun 19, 2024

Conversation

mertalev
Copy link
Contributor

@mertalev mertalev commented Jun 18, 2024

Description

Manual deduplication is impractical with a high number of duplicates. This PR adds two new buttons in the top right to either deduplicate all groups (keeping the largest asset from each) or simply keep all duplicates.

Implemented client-side to be consistent with how normal deduplication works. A server-side implementation makes sense as well since it would reduce the amount of data passed around and be part of the API for scripts, etc. I can change it if requested.

How Has This Been Tested?

  • Both buttons take no action until a confirmation
  • Keep All resolves all duplicates without trashing anything
  • Keep All displays a notification
  • Deduplicate All results in assets being trashed with no duplicate groups remaining afterwards
  • Deduplicate All displays a notification
  • The trashed assets are the smaller versions as expected
  • Running Duplicate Detection after Deduplicate All does not result in any duplicates being detected

web/src/lib/utils.ts Show resolved Hide resolved
@mertalev mertalev merged commit b3f9641 into main Jun 19, 2024
22 checks passed
@mertalev mertalev deleted the feat/web-bulk-deduplicate branch June 19, 2024 16:12
@aviv926
Copy link
Contributor

aviv926 commented Jun 21, 2024

@mertalev Does the marking of everything also include videos? If so, is it user selectable?

@mertalev
Copy link
Contributor Author

It does include videos, with no way to change that. You can make a feature request to make it more selective.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants