feat(mobile): render assets on device by default #10470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alextran1502
requested review from
fyfrey,
martyfuhry,
zackpollard and
shenlong-tanwen
alextran1502
changed the title
alextran1502
commented
Jun 18, 2024
| _syncService.removeAllLocalAlbumsAndAssets(); | ||
| } | ||
| return false; | ||
| } | ||
| final List<AssetPathEntity> onDevice = | ||
| await PhotoManager.getAssetPathList( |
There was a problem hiding this comment.
Maybe we can just get the Recents album here, which has all the assets?
There was a problem hiding this comment.
Hmm, the hash function only returns once it is done with all assets in the album. Maybe it would be better if we convert it to the stream for better user experience
alextran1502
added a commit
that referenced
this pull request
Jul 2, 2024
This reverts commit 32da9d9.
alextran1502
added a commit
that referenced
this pull request
Jul 2, 2024
alextran1502
added a commit
that referenced
this pull request
Jul 2, 2024
* feat(mobile): render asset on device by default * remove unused service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step in reworking the upload mechanism.
This PR removes the relationship between selected albums for backup so that it can be rendered on the timeline. All local assets are rendered on the timeline by default.