fix(server): consider all I-frames for video thumbnails #10471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The behavior of
-skip_frame nokeyapparently depends on the decoder. The HEVC and VP9 videos I tested on still process I-frames that aren't keyframes, but H.264 really only processes keyframes.-skip_frame nointrais consistent across decoders from what I can see.How Has This Been Tested?
Confirmed that the sample videos sent to me from #8683 have non-black thumbnails with this change. The thumbnails for HEVC and VP9 videos are the same as before from what I can tell.