Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): allow library id to be null in metadata search #10512

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

danieldietzler
Copy link
Member

No description provided.

@danieldietzler danieldietzler requested a review from jrasm91 June 20, 2024 20:53
@danieldietzler danieldietzler changed the title fix: allow library id to be null in metadata search fix(server): allow library id to be null in metadata search Jun 20, 2024
@danieldietzler danieldietzler force-pushed the fix/search-library-id branch from 81e9a5f to 72ac175 Compare June 20, 2024 20:54
Comment on lines -196 to -199
/// Please note: This property should have been non-nullable! Since the specification file
/// does not include a default value (using the "default:" property), however, the generated
/// source code must fall back to having a nullable type.
/// Consider adding a "default:" property in the specification file to hide this note.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LMAO

Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@alextran1502 alextran1502 merged commit 5e9a7b1 into main Jun 20, 2024
22 checks passed
@alextran1502 alextran1502 deleted the fix/search-library-id branch June 20, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants