Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mobile): inconsistent thumbnail's label #10589

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Conversation

RanKKI
Copy link
Contributor

@RanKKI RanKKI commented Jun 24, 2024

fixed the map's label and the place/person's label do not match, ( + map's labels look weird in other languages.

Also, make it display two lines for the label; long label should show '...' and should not ignore the padding.

Screenshots

Before After
Simulator Screenshot - iPhone 15 Pro - 2024-06-24 at 22 16 38 Simulator Screenshot - iPhone 15 Pro - 2024-06-24 at 22 17 56
Simulator Screenshot - iPhone 15 Pro - 2024-06-24 at 22 16 41 Simulator Screenshot - iPhone 15 Pro - 2024-06-24 at 22 17 59
Simulator Screenshot - iPhone 15 Pro - 2024-06-24 at 22 16 44 Simulator Screenshot - iPhone 15 Pro - 2024-06-24 at 22 17 57

@RanKKI RanKKI marked this pull request as ready for review June 24, 2024 12:19
Copy link
Contributor

@alextran1502 alextran1502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alextran1502 alextran1502 merged commit 04f0e29 into immich-app:main Jun 24, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants