feat(web): use websocket to update the feature photo #10683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return websocketEvents.on('on_person_thumbnail', (personId: string) => { | ||
| people.map((person) => { | ||
| if (person.id === personId) { | ||
| person.updatedAt = Date.now().toString(); |
There was a problem hiding this comment.
Shouldn't this be new Date().toISOString()?
There was a problem hiding this comment.
This works too, the main objective is to have a different value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
following #9443
With this PR, if the server sends a thumbnail generation event of a person, the client updates the thumbnail of that person. This PR changes the value of
updatedAtto force the browser to fetch the new thumbnail. IMO, it's not a bad thing to change this value even if it's not the same as the one stored on the server:updatedAtis only used to force the browser to request a new thumbnail.How was this PR tested ?