refactor: rename searchMetadata to searchAssets #14151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will be a breaking change for projects that use openapi, right? |
danieldietzler
approved these changes
Nov 14, 2024
No, because the endpoint is the same. Names are just meaningless |
|
OpenAPI generates the method name based on the controller's method name |
jrasm91
force-pushed
the
refactor/rename-search-metadata
branch
from
bec3a73 to
ce851d2
Compare
yosit
pushed a commit
to yosit/immich
that referenced
this pull request
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The operation name
searchMetadatahas been renamed tosearchAssets. The URL, params, and all other parts of the endpoint signature remain unchanged.