Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added shortcuts, shift-multi select and missing menu options to Search (Galleryviewer) #14213

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

weathondev
Copy link
Contributor

The Galleryviewer component (used in the Search, Individual Share page & Memories page) was lacking the ability to to

  • shift multiselect
  • shortcuts like ctrl A, ctrl D, delete, force delete, archive

Fixed a small issue in the search related to #13460 - It was always removing the assets added to an album, even when 'not in any album' was not on.

Also created two more issues i found while working on this, which i will tackle next:

Copy link
Contributor

@alextran1502 alextran1502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thank you so much. I wonder if we can refactor the duplicate logic/action in the gallery-view and asset-grid view in the future.

@alextran1502 alextran1502 enabled auto-merge (squash) November 19, 2024 18:18
@alextran1502 alextran1502 merged commit 69e50d0 into immich-app:main Nov 19, 2024
33 checks passed
yosit pushed a commit to yosit/immich that referenced this pull request Nov 21, 2024
… Search (Galleryviewer) (immich-app#14213)

feat: Added shortcuts, shift-multi select and missing menu options to GalleryViewer (Search, Share, Memories)

Co-authored-by: Alex <alex.tran1502@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants