feat(server): clean up interrupted upload files #14265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldietzler
approved these changes
Nov 20, 2024
jrasm91
reviewed
Nov 20, 2024
bo0tzz
reviewed
Nov 20, 2024
|
@jrasm91 Done, is this what you are looking for? |
yosit
pushed a commit
to yosit/immich
that referenced
this pull request
Nov 21, 2024
* feat(server): clean up interrupted upload files * pr feedback * remove console.log * handle all errors * remove return in callback function * programming in bed is a bad idea
|
How can one clean the existing failed uploads? |
|
Manually |
|
@bo0tzz , but how exactly to distinguish stale objects from something that is going on right now? |
|
If you're using the storage template, anything left behind in upload after running the template job should be safe to remove. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.