Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): cannot upload folder with more than 100 files #14284

Merged
merged 3 commits into from
Nov 22, 2024
Merged

Conversation

alextran1502
Copy link
Contributor

Fixes #14283

@alextran1502 alextran1502 requested a review from bo0tzz November 21, 2024 14:54
@alextran1502 alextran1502 changed the title fix: web cannot upload folder with more than 100 files fix(web): cannot upload folder with more than 100 files Nov 21, 2024
Copy link
Member

@bo0tzz bo0tzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know the intricacies of recursion in JS, will that cause any issues?

@bo0tzz bo0tzz requested a review from jrasm91 November 21, 2024 15:04
@alextran1502
Copy link
Contributor Author

I tested, and it works as expected so besides semantically ugly, I don't think there is issue

Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will work fine, but it would be better to write it in a non-recursive way imo. A while loop would be better. You'd just need a utility function to convert readEntries to a promise.

@alextran1502 alextran1502 enabled auto-merge (squash) November 22, 2024 22:28
@alextran1502 alextran1502 merged commit 6d49298 into main Nov 22, 2024
36 checks passed
@alextran1502 alextran1502 deleted the fix-14283 branch November 22, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When uploading a folder with drag-and-drop only 100 entries are uploaded
3 participants