fix(server): don't delete offline files from disk when trash empties #14777
+295
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etnoy
force-pushed
the
fix/empty-offline-files
branch
from
44f240d to
91b3b6a
Compare
jrasm91
reviewed
Dec 18, 2024
Comment on lines
+253
to
+261
| let willDelete = deleteOnDisk; | ||
|
|
||
| if (asset.isOffline) { | ||
| /* We don't want to delete an offline asset because it is either... | ||
| ...missing from disk => don't delete the file since it doesn't exist where we expect | ||
| ...outside of any import path => don't delete the file since we're not responsible for it | ||
| ...matching an exclusion pattern => don't delete the file since we're not responsible for it */ | ||
| willDelete = false; | ||
| } |
There was a problem hiding this comment.
This logic already exists outside of this job. Why is it duplicated here again?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, immich deletes files after 30 days that are excluded or outside of import paths, including original files.
I can't find the original bug report (github? reddit?)
Also adds some e2e tests related to offline files