-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internationalization (German) of the mobile app. #246
Conversation
8263d1f
to
eba7fc5
Compare
1bb6fbf
to
2dd1df8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for a wonderful PR. Can you help me add a subsection in the section Development
in the README of how to set Localizely up and running?
Locale('de', 'DE') | ||
]; | ||
|
||
runApp(EasyLocalization( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see an option to choose the language, is it based on the phone settings? Do you have any link to the resource that I can read about this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It uses the target platform's locale. That's described here: https://docs.flutter.dev/development/accessibility-and-localization/internationalization (Easy localization uses flutter's localization infrastructure internally)
files: | ||
- file: mobile/assets/i18n/en-US.json | ||
locale_code: en | ||
- file: mobile/assets/i18n/de-DE.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be in the upload section? I believe we should have just en-US in the upload section, then have all the other languages in the download section so localizely updates them for us automatically?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I would add all existing JSON files to the upload section. That way manual JSON changes and localizely are always in-sync. Localizely seems to do a great job merging local and remote changes.
No description provided.