Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internationalization (German) of the mobile app. #246

Merged
merged 26 commits into from
Jul 7, 2022
Merged

Conversation

matthinc
Copy link
Contributor

No description provided.

@matthinc matthinc force-pushed the dev/i18n branch 2 times, most recently from 1bb6fbf to 2dd1df8 Compare June 23, 2022 13:13
@matthinc matthinc marked this pull request as ready for review June 27, 2022 15:08
@matthinc matthinc changed the title Internationalization Internationalization (German) of the mobile app. Jun 27, 2022
@matthinc matthinc requested a review from alextran1502 June 27, 2022 15:16
Copy link
Contributor

@alextran1502 alextran1502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for a wonderful PR. Can you help me add a subsection in the section Development in the README of how to set Localizely up and running?

Locale('de', 'DE')
];

runApp(EasyLocalization(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see an option to choose the language, is it based on the phone settings? Do you have any link to the resource that I can read about this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It uses the target platform's locale. That's described here: https://docs.flutter.dev/development/accessibility-and-localization/internationalization (Easy localization uses flutter's localization infrastructure internally)

mobile/lib/modules/asset_viewer/ui/exif_bottom_sheet.dart Outdated Show resolved Hide resolved
files:
- file: mobile/assets/i18n/en-US.json
locale_code: en
- file: mobile/assets/i18n/de-DE.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be in the upload section? I believe we should have just en-US in the upload section, then have all the other languages in the download section so localizely updates them for us automatically?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I would add all existing JSON files to the upload section. That way manual JSON changes and localizely are always in-sync. Localizely seems to do a great job merging local and remote changes.

@alextran1502 alextran1502 merged commit 2b5cef1 into main Jul 7, 2022
@alextran1502 alextran1502 deleted the dev/i18n branch July 7, 2022 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants