feat(web/server): Face thumbnail selection

[alextran1502]

This PR adds the ability to choose a different thumbnail for a person's face.

This mechanism requires the user to run the Detect faces job again for all data.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
immich	⬜️ Ignored (Inspect)			Jul 2, 2023 9:48pm

[jrasm91]

Can you merge this new endpoint into the already existing update person endpoint?

[jrasm91]

What about primary asset id? This id is also used for matching against right?

[alextran1502]

This is the asset to crop the face of the person from

[jrasm91]

Unless I am mistaken the API doesn't ever reference asset_face, AssetFaceEntity, or faces ever. That is an implementation detail. All the external client knows is that a person has a thumbnail and then can update it with an asset id. Personally, I think calling it something with "face" makes me think you are referring to the asset face table and that seems like an implementation detail.

[alextran1502]

It does here

immich/server/src/infra/repositories/person.repository.ts

Lines 80 to 82 in f21b9ac

	async getFaceById({ personId, assetId }: AssetFaceId): Promise<AssetFaceEntity | null> {
	return this.assetFaceRepository.findOneBy({ assetId, personId });
	}