-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web): select a range of assets #3086
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
This comment was marked as outdated.
This comment was marked as outdated.
d21597d
to
1e8a13d
Compare
I think if we implement the feature, it will have to work across the time bucket, otherwise people will get confused |
b7b3134
to
3697288
Compare
Done. Screencast.from.2023-07-02.23-58-53.webm |
37ec32c
to
3851d9e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I've tested and it works very well! Thank you. I only have one question addressed above about the implementation, other than that, feel free to merge if you feel like this is good to go
selectAssetCandidates(lastAssetMouseEvent); | ||
} | ||
|
||
const getLastSelectedAsset = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you help explaning this method?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, I wanted the selection to start from the most recently selected asset. There is no "proper" way to get the most recently added item from a set, and so we have to essentially convert it to an array and get the last element. This function is equivalent to:
const s = new Set();
[...s].pop();
Though, this implementation is much quicker and uses much less memory.
The shift key can be held to select a range of assets. Fixes: #2862
Hello! Is this planned for "Explore" modes too? |
I believe basically everything will use the timeline view at some point and consequently inherit this. |
It's not working in Archive for me. I'm on v1.70.0. |
The shift key can be held to select a range of assets.
Screencast.from.2023-07-02.19-15-27.webm
Fixes: #2862