refactor(server): modularize getFfmpegOptions
#3138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
refactor transcoding, make separate service
mertalev
force-pushed
the
refactor/transcoding
branch
from
fd9eab4 to
03e8b3b
Compare
mertalev
changed the title
getFfmpegOptions
brighteyed
reviewed
Jul 7, 2023
mertalev
commented
Jul 7, 2023
web/src/lib/components/admin-page/settings/ffmpeg/ffmpeg-settings.svelte
Show resolved
Hide resolved
jrasm91
reviewed
Jul 7, 2023
web/src/lib/components/admin-page/settings/ffmpeg/ffmpeg-settings.svelte
Show resolved
Hide resolved
jrasm91
approved these changes
Jul 7, 2023
Co-authored-by: Jason Rasmussen <jrasm91@gmail.com>
Co-authored-by: Jason Rasmussen <jrasm91@gmail.com>
jrasm91
reviewed
Jul 7, 2023
jrasm91
approved these changes
Jul 7, 2023
alextran1502
reviewed
Jul 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modularizes
getFfmpegOptionsinto separate handlers for each codec and adds enums for several transcoding settings.getFfmpegOptionshas become too complex and monolithic to make major changes to it without either increasing its complexity further or introducing bugs. This change makes the intended behavior for each codec much more explicit, and makes adding a new codec as simple as adding a new handler without affecting existing logic.Notably, the only major change is to the code structure. Existing behavior should be the same.
Testing
Tests are unchanged (except for the addition of an
inputOptionsproperty inTranscodeOptions) and all pass. I tried different transcoding settings and all were applied and transcoded correctly.