Enable swiping between assets #381

TCVinNYC · 2022-07-27T06:21:28Z

Adding left/right swiping between assets using PageViewer

This is Pr V2 because I'm a little dumb lol

…e between groups.

* Added context menu for album opionts * choose asset for album thumbnail * Refactor UpdateAlbumDto to accept albumThumbnailAssetId * implemented changing album cover on web * Fixed api change on mobile app

alextran1502

Hey man, thanks for this. Everything looks great I left a few comments. Besides that AMAZING!

alextran1502 · 2022-07-28T20:15:27Z

mobile/lib/modules/asset_viewer/ui/remote_photo_view.dart

-      scaleStateChangedCallback: _scaleStateChanged,
-      onScaleEnd: _onScaleListener,
+    return SizedBox(
+      height: MediaQuery.of(context).size.height,


Why do we need to wrap the SizedBox here?

Flutter throws an error for having undefined/infinite height and width.

Never mind, I guess I accidentally fixed it after I encountered the error haha

alextran1502 · 2022-07-28T20:16:41Z

mobile/lib/modules/asset_viewer/views/gallery_viewer.dart

+      },
+      [],
+    );
+    @override


Since you have used useEffect above, I think we don't need initState function here

https://pub.dev/documentation/flutter_hooks/latest/flutter_hooks/useEffect.html

alextran1502 · 2022-07-30T03:43:19Z

So I tested on an instance with 13000 photos/videos. There is no noticeable performance issue. The only issue is that when you double tap on an image to zoom, you cannot pinch with two fingers to zoom in/out. If you swipe left or right in zoom mode, it will navigate forward or backward. I think we will need a flag to handle the zoom or normal mode and which interaction can be done in each mode

TCVinNYC · 2022-07-30T08:21:17Z

Awesome!
Still going to move things around and only run things once for peace of mind haha
Once I figure out that, I'll fix the zooming issue.

alextran1502 · 2022-07-30T17:25:22Z

I think let's make fixing this PR a priority to merge it in. The dark mode PR might need a lot of additional works

…ckering (immich-app#413)

…#414) * Remove check due to logout always success * Added console log * Remove console.log * Up server version

…e album list at the same time

alextran1502 · 2022-08-01T03:33:08Z

If I click on the first asset in the list, the scrolling is disabled
I still cannot use two fingers to zoom in and out when pinching

Tested on Samsung S9

TCVinNYC · 2022-08-01T03:55:31Z

It throws an exception error, uploading a fix in a few minutes.
That's interesting, I'll test on Android emulator. I don't have an android atm

TCVinNYC · 2022-08-01T07:26:49Z

Did some more cleanup, and I added more files to attempt to save the sorted list in a Hive box, but I'm having issues getting it to save.

All swipes & gestures for the main page should work.

Seems fine on iPhone, and Android emulator except Double Taps don't register as "zoomed in" until you move the image.

alextran1502 · 2022-08-03T02:31:09Z

mobile/lib/modules/asset_viewer/views/video_viewer_page.dart

@@ -31,66 +25,17 @@ class VideoViewerPage extends HookConsumerWidget {

    String jwtToken = Hive.box(userInfoBox).get(accessTokenKey);

-    void showInfo() {


Why do we remove these functions?

GalleryView already does the same function.

TCVinNYC · 2022-08-03T02:32:05Z

That's so interesting.
How many assets are in this album?

Maybe this if (list.isEmpty) is causing this problem.

alextran1502 · 2022-08-03T02:33:57Z

That's so interesting. How many assets are in this album?

Maybe this if (list.isEmpty) is causing this problem.

There is 1 asset in the album. list.isEmpty is not a problem since it is specific for getting the list of albums for backing up. This is the sharing album feature

alextran1502 · 2022-08-03T02:34:33Z

This is the problem :)

album_viewer_page.dart line 186

TCVinNYC · 2022-08-03T02:35:32Z

Ohh haha, that's okay. I'll remove it after I'm done figuring out the EXIF issue.

TCVinNYC · 2022-08-03T02:36:03Z

Try selecting an album with more than 3 items haha.

alextran1502 · 2022-08-03T02:39:30Z

Another behavior I just discovered is that you can only swipe in one date group. See the video below.

Android.Emulator.-.PixelXLAPI30_5554.2022-08-02.21-38-15.mp4

TCVinNYC · 2022-08-03T02:40:14Z

Yeah don't worry, that was only an issue from last commit because I was fixing the albums situation first lol

alextran1502 · 2022-08-03T02:46:08Z

mobile/lib/modules/asset_viewer/views/gallery_viewer.dart

+
+  @override
+  Widget build(BuildContext context, WidgetRef ref) {
+    //get the list of whats in the assets


If this works, I am OK leaving this here. I don't want to use Hive if we don't really need it

I'd like to move it if we could mainly because the album list is already sorted, so it's just reduntant. I can keep it here if you'd really like.

Figured out that I needed to at least move this method somewhere else so it didn't conflict with the Albums swipe.
The latest commit should work perfectly for swipes in all areas now.

alextran1502 · 2022-08-03T02:46:28Z

Ok I think that is all I have for this route. I am pretty happy with the current behavior, very slick. Thanks again!

TCVinNYC · 2022-08-03T03:34:00Z

Ok I think that is all I have for this route. I am pretty happy with the current behavior, very slick. Thanks again!

Appreciate the feedback!

… assets

* Refactor sharing to album * Added library page in the bottom navigation bar * Refactor SharedAlbumService to album service * Refactor apiProvider to its file * Added image grid * render album thumbnail * Using the wrap to render thumbnail and album info better * Navigate to album viewer * After deletion, navigate to the respective page of the shared and non-shared album * Correctly remove album in local state * Refactor create album page * Implemented create non-shared album

alextran1502 · 2022-08-03T05:08:03Z

Please fixed the merge conflict, I will have this merged in as soon as tomorrow :)

TCVinNYC · 2022-08-03T05:13:19Z

@alextran1502 I don't have write access to fix things here. I could try doing it manually though if you'd rather me do that haha

alextran1502 · 2022-08-03T05:16:22Z

@alextran1502 I don't have write access to fix things here. I could try doing it manually though if you'd rather me do that haha

What you would like to do is to merge upstream and then fix the merge conflict :) That is how Git solves these conflict issue

TCVinNYC · 2022-08-03T05:17:05Z

@alextran1502 I don't have write access to fix things here. I could try doing it manually though if you'd rather me do that haha

What you would like to do is to merge upstream and then fix the merge conflict :) That is how Git solves these conflict issue

Ohh I see, thanks for the heads up!!

alextran1502 · 2022-08-03T05:17:29Z

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork Here is a relevant guide

alextran1502 · 2022-08-03T14:52:26Z

mobile/lib/constants/hive_box.dart

@@ -16,3 +16,7 @@ const String backupInfoKey = "immichBackupAlbumInfoKey"; // Key 1
 // Github Release Info
 const String hiveGithubReleaseInfoBox = "immichGithubReleaseInfoBox"; // Box
 const String githubReleaseInfoKey = "immichGithubReleaseInfoKey"; // Key 1
+
+// Image Sorted List Info


Can we also remove these since we don't use them?

alextran1502 · 2022-08-03T14:52:57Z

mobile/ios/Runner.xcodeproj/project.pbxproj

@@ -361,7 +361,7 @@
 				CODE_SIGN_IDENTITY = "Apple Development";


Please exclude this file from the PR

TCVinNYC added 2 commits July 27, 2022 02:20

swiping between assets works, current has a hacky way to let you swip…

79849fd

…e between groups.

removed testClass

598383f

TCVinNYC mentioned this pull request Jul 27, 2022

[Feature] Swipe between photos #121

Closed

alextran1502 added 7 commits July 27, 2022 11:07

[Localizely] Translations update (immich-app#384)

a305db9

Added Japanese/Polish/Finish and fix Italian/Spanish translation

6dbca8d

[WEB] Select album thumbnail (immich-app#383)

ef4136d

* Added context menu for album opionts * choose asset for album thumbnail * Refactor UpdateAlbumDto to accept albumThumbnailAssetId * implemented changing album cover on web * Fixed api change on mobile app

Up version for release

97238a1

Remove AxiosError import due to production build error

8b9fd67

Update readme

2de34f7

Added changlog for Fdroid release

1ba998a

alextran1502 reviewed Jul 28, 2022

View reviewed changes

alextran1502 added 3 commits July 29, 2022 12:54

Fixed github action to conform with the move to org

8102e3b

Update donation info

746bec9

Update donation info

2aea087

fixed some German translations (immich-app#399)

dc61fd9

matthinc and others added 5 commits July 31, 2022 15:56

Load low- and high quality thumbnail in the same img tag to avoid fli…

0ac9fe5

…ckering (immich-app#413)

Fixed logging out not redirect correctly in reverse proxy (immich-app…

03e7a25

…#414) * Remove check due to logout always success * Added console log * Remove console.log * Up server version

Disable scroll when zoomed + code cleanup

fe37386

Fixed problem with Recent (isAll) album is both in exclude and includ…

f7dc916

…e album list at the same time

Remove print statement

0e85b0f

TCVinNYC added 2 commits August 1, 2022 03:18

fixes android zoom in and crash when selecting first/last asset

1bb5259

reenabled Hero animation and Swipe for videos

d7b415e

TCVinNYC added 2 commits August 2, 2022 14:46

Should fix double tap zoom issue

1d71be7

basic album swipe (exif info does not work in albums)

938e93e

alextran1502 reviewed Aug 3, 2022

View reviewed changes

TCVinNYC and others added 4 commits August 2, 2022 23:41

fixes EXIF on Albums, GalleryViewer should have zero issues

4e4fa8b

Reenable Swipe between all groups

e13660b

Now everything should work, this is without using Hive to save sorted…

2f5d67b

… assets

alextran1502 linked an issue Aug 3, 2022 that may be closed by this pull request

[Feature] Swipe between photos #121

Closed

TCVinNYC added 4 commits August 3, 2022 01:19

cleanup

1279edc

removed Hive asset code

cafcbbf

Merge branch 'main' into pr/TCVinNYC/1

78a55f8

added swipe feature to search assets

27d0144

alextran1502 reviewed Aug 3, 2022

View reviewed changes

alextran1502 added 2 commits August 3, 2022 15:28

remove unsued Hive box

c007747

Removed file project.pbxproj in PR

d66eb8c

alextran1502 merged commit 8c184dc into immich-app:main Aug 3, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable swiping between assets #381

Enable swiping between assets #381

TCVinNYC commented Jul 27, 2022

alextran1502 left a comment

alextran1502 Jul 28, 2022

TCVinNYC Jul 29, 2022

TCVinNYC Jul 30, 2022

alextran1502 Jul 28, 2022

alextran1502 commented Jul 30, 2022

TCVinNYC commented Jul 30, 2022

alextran1502 commented Jul 30, 2022

alextran1502 commented Aug 1, 2022 •

edited

Loading

TCVinNYC commented Aug 1, 2022

TCVinNYC commented Aug 1, 2022

alextran1502 Aug 3, 2022

TCVinNYC Aug 3, 2022

TCVinNYC commented Aug 3, 2022 •

edited

Loading

alextran1502 commented Aug 3, 2022

alextran1502 commented Aug 3, 2022 •

edited

Loading

TCVinNYC commented Aug 3, 2022

TCVinNYC commented Aug 3, 2022

alextran1502 commented Aug 3, 2022

TCVinNYC commented Aug 3, 2022

alextran1502 Aug 3, 2022

TCVinNYC Aug 3, 2022

TCVinNYC Aug 3, 2022

alextran1502 commented Aug 3, 2022

TCVinNYC commented Aug 3, 2022 •

edited

Loading

alextran1502 commented Aug 3, 2022

TCVinNYC commented Aug 3, 2022

alextran1502 commented Aug 3, 2022

TCVinNYC commented Aug 3, 2022

alextran1502 commented Aug 3, 2022

alextran1502 Aug 3, 2022

alextran1502 Aug 3, 2022

		@@ -31,66 +25,17 @@ class VideoViewerPage extends HookConsumerWidget {

		String jwtToken = Hive.box(userInfoBox).get(accessTokenKey);

		void showInfo() {

		@@ -361,7 +361,7 @@
		CODE_SIGN_IDENTITY = "Apple Development";

Enable swiping between assets #381

Enable swiping between assets #381

Conversation

TCVinNYC commented Jul 27, 2022

alextran1502 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alextran1502 commented Jul 30, 2022

TCVinNYC commented Jul 30, 2022

alextran1502 commented Jul 30, 2022

alextran1502 commented Aug 1, 2022 • edited Loading

TCVinNYC commented Aug 1, 2022

TCVinNYC commented Aug 1, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TCVinNYC commented Aug 3, 2022 • edited Loading

alextran1502 commented Aug 3, 2022

alextran1502 commented Aug 3, 2022 • edited Loading

TCVinNYC commented Aug 3, 2022

TCVinNYC commented Aug 3, 2022

alextran1502 commented Aug 3, 2022

TCVinNYC commented Aug 3, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alextran1502 commented Aug 3, 2022

TCVinNYC commented Aug 3, 2022 • edited Loading

alextran1502 commented Aug 3, 2022

TCVinNYC commented Aug 3, 2022

alextran1502 commented Aug 3, 2022

TCVinNYC commented Aug 3, 2022

alextran1502 commented Aug 3, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alextran1502 commented Aug 1, 2022 •

edited

Loading

TCVinNYC commented Aug 3, 2022 •

edited

Loading

alextran1502 commented Aug 3, 2022 •

edited

Loading

TCVinNYC commented Aug 3, 2022 •

edited

Loading