Share assets from mobile to other apps #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthinc
force-pushed
the
dev/mobile-share
branch
2 times, most recently
from
0311c2b to
bf09e26
Compare
|
It would be great if you could test the functionality on ios. It might behave differently than the native android sharing dialog. |
alextran1502
reviewed
Aug 8, 2022
| builder: (BuildContext buildContext) { | ||
| _shareService | ||
| .shareAsset(asset) | ||
| .then((_) => Navigator.pop(buildContext)); |
There was a problem hiding this comment.
Can we use AutoRouter.of(context).pop() to keep navigation within the auto_router package?
There was a problem hiding this comment.
This does not seem to work. DeleteDialog also uses Navigator.of(buildContext).pop().
There was a problem hiding this comment.
Ah, ok then. We can leave it as it
matthinc
force-pushed
the
dev/mobile-share
branch
from
363da62 to
019fd45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#241