Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(server): optimize get asset query #7176

Merged
merged 15 commits into from
Feb 18, 2024
Merged

feat(server): optimize get asset query #7176

merged 15 commits into from
Feb 18, 2024

Conversation

mertalev
Copy link
Contributor

@mertalev mertalev commented Feb 18, 2024 •
edited
Loading

Description

This PR fixes #7166 by simplifying the legacy query used in getAllAssets:

  • Removes unnecessary joins
  • Fetches data in one query vs two
    • TypeORM split the old query into two: a query to fetch the IDs and a second query to fetch the assets
  • Removes DISTINCT clause due to use of limit/offset rather than skip/take
  • Adds index on fileCreatedAt for faster sorting
  • Adds updated method to asset repository, removing the legacy code

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Feb 18, 2024 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: cb67b3f
Status: ✅  Deploy successful!
Preview URL: https://0dcb070f.immich.pages.dev
Branch Preview URL: https://feat-server-optimize-get-ass.immich.pages.dev

View logs

@mertalev mertalev requested review from jrasm91 and fyfrey February 18, 2024 04:53
fyfrey
fyfrey approved these changes Feb 18, 2024
View reviewed changes
Copy link
Contributor

@fyfrey fyfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

danieldietzler
danieldietzler approved these changes Feb 18, 2024
View reviewed changes
Copy link
Member

@danieldietzler danieldietzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alextran1502 alextran1502 merged commit 857ec04 into main Feb 18, 2024
25 checks passed
@alextran1502 alextran1502 deleted the feat/server-optimize-get-asset-query branch February 18, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldietzler danieldietzler danieldietzler approved these changes

@alextran1502 alextran1502 alextran1502 approved these changes

@fyfrey fyfrey fyfrey approved these changes

@jrasm91 jrasm91 Awaiting requested review from jrasm91

Assignees
No one assigned
Labels
🗄️server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

800,000+ Assets, Performance is unusable
4 participants
@mertalev @fyfrey @alextran1502 @danieldietzler