fix(server): only queue ml / transcoding jobs after thumbnail generation on upload #7516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
1017a1e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c7564521.immich.pages.dev |
| Branch Preview URL: | https://fix-jpeg-queuing-ondone.immich.pages.dev |
jrasm91
approved these changes
Feb 29, 2024
|
I've been using that functionality for rescan faces after detection score change. Now there is no chance to rerun face detection selectively. It would be nice to add a separate function for face re-detection same as "Refresh thumbnails". |
|
Face detection skips any assets that already have faces, so I don't think there's a difference between running thumbnail generation and running a "without" job for face detection. |
There is a discussion about it... |
|
Relevant XKCD haha But I agree it'd be nice to have a face detection variant of Refresh Thumbnails |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Re-running thumbnail generation has the side effect of queueing all ML tasks as well as transcoding. This is unnecessary and can be detrimental in the case of ML due to the indices being degraded. There's currently no way to just re-generate thumbnails (such as with a different quality setting, or after a certain PR).
This PR addresses this by selectively queueing ML and transcoding only on upload.