feat(web,mobile) Allow videos to be looped in the detail viewer #8615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto loop-videos
jrasm91
approved these changes
Apr 10, 2024
|
@alextran1502 can you test this when you have a second? |
|
I'll take a look at this and test it tomorrow |
alextran1502
approved these changes
May 14, 2024
|
i update both the mobile app and the server (1.105.0 build 139 and 1.105.1) but still cannot see the option in the Asset Viewer settings section on the mobile App (Android) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a setting to the web and mobile version to make videos automatically loop in the detail viewer. The user can decide if he wants this behaviour or not (default currently enabled).
Web setting:
Mobile setting:
It is my first contribution and I am complete new to flutter and have only little svelte experience, so I am open for constructive feedback :)