Option to disable readonly status of external libraries #9188
Conversation
|
I see the library's |
benmccann
force-pushed
the
library-rdonly
branch
from
abed70d to
6c1a020
Compare
web/src/lib/components/photos-page/actions/delete-assets.svelte
Outdated
Show resolved
Hide resolved
benmccann
changed the title
| @@ -201,6 +201,10 @@ export class AssetRepository implements IAssetRepository { | |||
| ); | |||
| } | |||
|
|
|||
| async setReadOnlyForLibrary(libraryId: string, isReadOnly: boolean): Promise<void> { | |||
| await this.repository.update({ library: { id: libraryId } }, { isReadOnly }); | |||
There was a problem hiding this comment.
External libraries can have isVisible:false motion parts of extracted live photos and they need to be excluded from this update.
There was a problem hiding this comment.
okay. I've updated it, but you should check that I understood correctly: 3e19aef
There was a problem hiding this comment.
Yeah, I think that looks good. Will have to test later with motion photos to make sure are working as expected.
|
Hey, thanks for working on this and sorry for the confusion/back and forth around this topic. Internally we have had a lot of discussions about the direction we want to take external libraries. Long story short, we decided to go ahead with the implementation laid out in #9235. |
This is an updated version of @valpackett's #8943 with the code review comments addressed
closes #8943
closes #5449
ref #8438